Update factory image tags to use SHA256 hashes#3075
Merged
Conversation
Signed-off-by: Alan Chin <akchin@us.ibm.com>
Signed-off-by: Alan Chin <akchin@us.ibm.com>
shalberd
reviewed
Jan 10, 2023
shalberd
reviewed
Jan 10, 2023
shalberd
reviewed
Jan 10, 2023
shalberd
reviewed
Jan 10, 2023
shalberd
reviewed
Jan 10, 2023
shalberd
reviewed
Jan 10, 2023
shalberd
reviewed
Jan 10, 2023
shalberd
reviewed
Jan 10, 2023
shalberd
reviewed
Jan 10, 2023
shalberd
reviewed
Jan 10, 2023
shalberd
reviewed
Jan 10, 2023
Signed-off-by: Alan Chin <akchin@us.ibm.com>
shalberd
reviewed
Jan 10, 2023
shalberd
reviewed
Jan 10, 2023
Contributor
shalberd
reviewed
Jan 11, 2023
Signed-off-by: Alan Chin <akchin@us.ibm.com>
Signed-off-by: Alan Chin <akchin@us.ibm.com>
kevin-bates
approved these changes
Jan 11, 2023
kevin-bates
left a comment
Member
There was a problem hiding this comment.
These changes LGTM. I do agree with @shalberd that the description of Image Name should be amended with or name and SHA256-digest for consistency.
Contributor
|
Looking good, now the only integration test failing is https://github.com/elyra-ai/elyra/blob/main/tests/integration/pipeline.ts#L135 complex pipeline test stuff |
Contributor
Yes, I think that short addition is a good idea in terms of being brief and terse. |
Signed-off-by: Alan Chin <akchin@us.ibm.com>
Signed-off-by: Alan Chin <akchin@us.ibm.com>
Contributor
|
LGTM, can be merged, thanks to you two, great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Signed-off-by: Alan Chin akchin@us.ibm.com
Closes #3074
What changes were proposed in this pull request?
Update factory runtime images to use SHA256 hashes instead of the tag name.
Human readable name still exists in the form of the display_name.
How was this pull request tested?
Developer's Certificate of Origin 1.1